X-Git-Url: https://git.friedersdorff.com/?a=blobdiff_plain;f=keyboard%2Fgh60%2Fmatrix.c;h=3ba6801fbfabafe9b7d913caab99b39288f69231;hb=b057511f45de020c43021f2991569a53c2b929c9;hp=6ded8158ff460be2df5d38a41588b12abf3dc111;hpb=4701b08b71b187cb3d015bec7e05d30e35c344ac;p=max%2Ftmk_keyboard.git

diff --git a/keyboard/gh60/matrix.c b/keyboard/gh60/matrix.c
index 6ded8158..3ba6801f 100644
--- a/keyboard/gh60/matrix.c
+++ b/keyboard/gh60/matrix.c
@@ -34,13 +34,12 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 static uint8_t debouncing = DEBOUNCE;
 
 /* matrix state(1:on, 0:off) */
-static uint16_t *matrix;
-static uint16_t *matrix_debouncing;
-static uint16_t matrix0[MATRIX_ROWS];
-static uint16_t matrix1[MATRIX_ROWS];
-static bool is_modified;
+static matrix_row_t *matrix;
+static matrix_row_t *matrix_debouncing;
+static matrix_row_t matrix0[MATRIX_ROWS];
+static matrix_row_t matrix1[MATRIX_ROWS];
 
-static uint16_t read_cols(void);
+static matrix_row_t read_cols(void);
 static void init_cols(void);
 static void unselect_rows(void);
 static void select_row(uint8_t row);
@@ -71,36 +70,32 @@ void matrix_init(void)
         matrix[i] = 0;
         matrix_debouncing[i] = 0;
     }
-    is_modified = false;
 }
 
 uint8_t matrix_scan(void)
 {
     for (uint8_t i = 0; i < MATRIX_ROWS; i++) {
-        //unselect_rows();
         select_row(i);
         _delay_us(30);  // without this wait read unstable value.
-        uint16_t cols = read_cols();
+        matrix_row_t cols = read_cols();
         if (matrix_debouncing[i] != cols) {
             matrix_debouncing[i] = cols;
             if (debouncing) {
                 debug("bounce!: "); debug_hex(debouncing); debug("\n");
             }
             debouncing = DEBOUNCE;
-            is_modified = false;
         }
         unselect_rows();
     }
-    //unselect_rows();
 
     if (debouncing) {
-        debouncing--;
-        _delay_ms(1);
-    } else {
-        uint16_t *tmp = matrix;
-        matrix = matrix_debouncing;
-        matrix_debouncing = tmp;
-        is_modified = true;
+        if (--debouncing) {
+            _delay_ms(1);
+        } else {
+            matrix_row_t *tmp = matrix;
+            matrix = matrix_debouncing;
+            matrix_debouncing = tmp;
+        }
     }
 
     return 1;
@@ -108,30 +103,25 @@ uint8_t matrix_scan(void)
 
 bool matrix_is_modified(void)
 {
-    return is_modified;
-}
-
-inline
-bool matrix_has_ghost(void)
-{
-    return false;
+    if (debouncing) return false;
+    return true;
 }
 
 inline
 bool matrix_is_on(uint8_t row, uint8_t col)
 {
-    return (matrix[row] & (1<<col));
+    return (matrix[row] & ((matrix_row_t)1<<col));
 }
 
 inline
-uint16_t matrix_get_row(uint8_t row)
+matrix_row_t matrix_get_row(uint8_t row)
 {
     return matrix[row];
 }
 
 void matrix_print(void)
 {
-    print("\nr/c 01234567890ABCDEF\n");
+    print("\nr/c 0123456789ABCDEF\n");
     for (uint8_t row = 0; row < MATRIX_ROWS; row++) {
         phex(row); print(": ");
         pbin_reverse16(matrix_get_row(row));
@@ -167,7 +157,7 @@ static void  init_cols(void)
     PORTB |=  (1<<6 | 1<< 5 | 1<<4 | 1<<3 | 1<<1 | 1<<0);
 }
 
-static uint16_t read_cols(void)
+static matrix_row_t read_cols(void)
 {
     return (PINF&(1<<0) ? 0 : (1<<0)) |
            (PINF&(1<<1) ? 0 : (1<<1)) |