Bugfix: wrong order during init

All credits to Tensor@geekhack
http://geekhack.org/index.php?topic=48106.msg1076661#msg1076661

diff --git a/keyboard/ergodox/ergodox.c b/keyboard/ergodox/ergodox.c
index f8b3d82efb3e26f26e139c4fc92194d03fc6378b..c6a831487f781a1b901aa007b0b78b44ecb3b0a6 100644 (file)
--- a/keyboard/ergodox/ergodox.c
+++ b/keyboard/ergodox/ergodox.c
@@ -62,8 +62,10 @@ void init_ergodox(void)
     PORTC |=  (1<<7);
     PORTD |=  (1<<7 | 1<<5 | 1<<4);
     PORTE |=  (1<<6);
+}
 
-    // blink leds
+void ergodox_blink_all_leds(void)
+{
     ergodox_led_all_off();
     ergodox_led_all_set(LED_BRIGHTNESS_HI);
     ergodox_led_all_on();

diff --git a/keyboard/ergodox/ergodox.h b/keyboard/ergodox/ergodox.h
index a0511ff3448dfb7d4fec348b50b17197e5e11ebf..bcd839c8ea945f67577b2d390ea2f8fcf374bd98 100644 (file)
--- a/keyboard/ergodox/ergodox.h
+++ b/keyboard/ergodox/ergodox.h
@@ -46,6 +46,7 @@ Most used files are located at
 #define OLATB           0x15
 
 void init_ergodox(void);
+void ergodox_blink_all_leds(void);
 uint8_t init_mcp23018(void);
 uint8_t ergodox_left_leds_update(void);
 

diff --git a/keyboard/ergodox/matrix.c b/keyboard/ergodox/matrix.c
index e50932c92c25ffc752fc4a7098d5cb6e82c2599f..2103a01814e525616f84383d5e08b275af92ebbd 100644 (file)
--- a/keyboard/ergodox/matrix.c
+++ b/keyboard/ergodox/matrix.c
@@ -71,6 +71,7 @@ void matrix_init(void)
     // initialize row and col
     init_ergodox();
     mcp23018_status = init_mcp23018();
+    ergodox_blink_all_leds();
     unselect_rows();
     init_cols();